Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect comment #3017

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Fix incorrect comment #3017

merged 1 commit into from
Sep 30, 2022

Conversation

xrchz
Copy link
Contributor

@xrchz xrchz commented Sep 27, 2022

bit-reversal permutation is not idempotent

@xrchz
Fix incorrect comment
9ac605c 
bit-reversal permutation is not idempotent
dankrad
dankrad approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@dankrad dankrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's indeed an involution and not idempotent, my bad.

@hwwhww hwwhww added the Deneb was called: eip-4844 label Sep 30, 2022
@hwwhww hwwhww merged commit 55c195d into ethereum:dev Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww approved these changes

@dankrad dankrad dankrad approved these changes

Assignees
No one assigned
Labels
Deneb was called: eip-4844
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrchz @dankrad @hwwhww