Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor patch to bytes formatting in capella #2890

Merged
merged 1 commit into from
May 10, 2022
Merged

minor patch to bytes formatting in capella #2890

merged 1 commit into from
May 10, 2022

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented May 10, 2022 •
edited
Loading

both the previous and current version are bit "pythonic" but to_bytes requiring an endianness param is likely to lead to more confusion than using the b python bytes notation.

@djrtwo djrtwo requested a review from hwwhww May 10, 2022 15:38
@hwwhww hwwhww added the Capella label May 10, 2022
@hwwhww hwwhww merged commit 8abf239 into dev May 10, 2022
@hwwhww hwwhww deleted the format branch May 10, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
Capella
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djrtwo @hwwhww