Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP implementation of Danksharding #2792

Merged
merged 69 commits into from
Jul 18, 2022
Merged

WIP implementation of Danksharding #2792

merged 69 commits into from
Jul 18, 2022

Conversation

dankrad
Copy link
Contributor

@dankrad dankrad commented Jan 7, 2022

@hwwhww hwwhww added DO NOT MERGE general:RFC Request for Comments scope:sharding Sharding and removed general:RFC Request for Comments labels Jan 7, 2022
Nashatyrev
Nashatyrev reviewed Jan 12, 2022
View reviewed changes
Copy link
Member

@Nashatyrev Nashatyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor questions and cleanup suggestions

dankrad and others added 22 commits July 6, 2022 18:19
@dankrad @hwwhww
Update specs/sharding/polynomial-commitments.md
6e97e55 
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
@dankrad @hwwhww
Update specs/sharding/polynomial-commitments.md
ac3b91d 
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
@dankrad @hwwhww
Update specs/sharding/polynomial-commitments.md
f1d1305 
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
@dankrad @hwwhww
Update specs/sharding/polynomial-commitments.md
cd87bf2 
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
@dankrad @hwwhww
Update specs/sharding/polynomial-commitments.md
9678703 
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
@dankrad @hwwhww
Update specs/sharding/polynomial-commitments.md
bc307a0 
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
@dankrad @hwwhww
Update specs/sharding/polynomial-commitments.md
e5eefe3 
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
@dankrad @hwwhww
Update specs/sharding/polynomial-commitments.md
96f8599 
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
@dankrad @hwwhww
Update specs/sharding/polynomial-commitments.md
f03bb2c 
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
@dankrad
Z1 -> inf_G1
b236e36
@dankrad
Fix degree proof bound
7099725
@dankrad
SignedShardSample -> ShardSample
8dfaf4c
@dankrad
Typo
dc91ef3
@dankrad
Don't allow 0 for next_power_of_two
9268a4d
@dankrad
Remove unused ROOT_OF_UNITY constant
ec68256
@dankrad
Throwaway variable name
d172dcf
@dankrad
Fix function documentation of bls_modular_inverse
0624431
@dankrad
Builder block bid increase by at least 1%, no RANDAO processing in bu…
2a8709a 
…ilder blocks
@dankrad
Fix tocs
8da1320
@dankrad
Fix tocs
9008bfc
@dankrad
Fix typo
302228c
@dankrad @asn-d6
Update specs/sharding/polynomial-commitments.md
f62571a 
Co-authored-by: George Kadianakis <desnacked@riseup.net>
@dankrad dankrad marked this pull request as ready for review July 7, 2022 21:40
@dankrad
Copy link
Contributor Author

dankrad commented Jul 7, 2022

Now ready for merge @djrtwo

djrtwo
djrtwo approved these changes Jul 14, 2022
View reviewed changes
specs/sharding/beacon-chain.md Outdated
```python
def process_block(state: BeaconState, block: BeaconBlock) -> None:
def process_beacon_block(state: BeaconState, block: BeaconBlock) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming this is going to have large ripple effects in testing, tooling, and any rile with the function as dependency. Suggest keeping the same name and just adding the process_intermediate_block

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

process_intermediate_block

Did we settle on "builder block" (and "proposer block")?

@hwwhww
Copy link
Contributor

hwwhww commented Jul 15, 2022

Does it make sense to rebase/squash the commits a bit? Or even do "Squash and merge"?

@djrtwo
Copy link
Contributor

djrtwo commented Jul 18, 2022

I'm fine with squash and merge

@djrtwo djrtwo merged commit 02a2b71 into dev Jul 18, 2022
@djrtwo djrtwo deleted the danksharding branch July 18, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinDrake JustinDrake JustinDrake left review comments

@arnetheduck arnetheduck arnetheduck left review comments

@vbuterin vbuterin vbuterin left review comments

@asn-d6 asn-d6 asn-d6 left review comments

@Nashatyrev Nashatyrev Nashatyrev left review comments

@hwwhww hwwhww hwwhww left review comments

@terencechain terencechain terencechain left review comments

@mratsim mratsim mratsim left review comments

@graemecode graemecode graemecode left review comments

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
scope:sharding Sharding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.