Add CONFIG_NAME to configs
#2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runtime configurations apply to a certain network and the name of that network is useful for humans such that they can talk about it. Some of the existing configs already include a `CONFIG_NAME` toggle - might as well add it here as well and avoid some confusion - this name above all becomes useful in the beacon API. By extension, the `CONFIG_NAME` config will appear in the beacon api as a result of being defined here.
arnetheduck
force-pushed
the
config-name
branch
from
7cc512f to
46bc206
Compare
hwwhww
approved these changes
Jan 1, 2022
There was a problem hiding this comment.
It was removed when we had config file per fork per network, e.g., mainnet/phase0.yaml, mainnet/altair.yaml, etc. (#2332)
I think it's okay to add it back since now we only have one config file per network, but let's leave this issue open for a couple days in case there is any objection.
|
I think Teku has added this to all our network config files anyway to preserve backwards compatibility of the config REST API endpoint. |
djrtwo
approved these changes
Jan 3, 2022
dapplion
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime configurations apply to a certain network and the name of that
network is useful for humans such that they can talk about it.
Some of the existing configs already include a
CONFIG_NAMEtoggle -might as well add it here as well and avoid some confusion - this name
above all becomes useful in the beacon API.
By extension, the
CONFIG_NAMEconfig will appear in the beacon api asa result of being defined here.