Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring more clarity to notify_forkchoice_updated calls #2745

Merged
merged 4 commits into from
Nov 26, 2021
Merged

Bring more clarity to notify_forkchoice_updated calls #2745

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ece777
Bring more clarity to notify_forkchoice_updated calls
mkalinin Nov 24, 2021
b437733
Polish notify_forkchoice_updated description as per review
mkalinin Nov 25, 2021
7a8f236
Fix notify_forkchoice_updated description as per review
mkalinin Nov 25, 2021
d237491
minor typo
djrtwo Nov 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion specs/merge/fork-choice.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,11 @@ def notify_forkchoice_updated(self: ExecutionEngine,
```

*Note*: The call of the `notify_forkchoice_updated` function maps on the `POS_FORKCHOICE_UPDATED` event defined in the [EIP-3675](https://eips.ethereum.org/EIPS/eip-3675#definitions).
As per EIP-3675, before a post-transition block is finalized, `notify_forkchoice_updated` must be called with `finalized_block_hash = Hash32()`.
As per EIP-3675, before a post-transition block is finalized, `notify_forkchoice_updated` MUST be called with `finalized_block_hash = Hash32()`.

*Note*: Client software MUST NOT call this function until the transition conditions are met on the PoW network, i.e. there exists a block for which `is_valid_terminal_pow_block` function returns `True`.

*Note*: Client software MUST call this function to initiate the payload build process to produce the merge transition block; the `head_block_hash` parameter MUST be set to the hash of a terminal PoW block in this case.

## Helpers

Expand Down