How to write tests for the consensus layer #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protolambda
reviewed
Nov 1, 2021
Nice to find you here too. Yes, I've been writing helping out EF with documentation and testing for a while now, long before I've even heard of Optimism. I'm glad it helps. It's always difficult to know how much detail to put in a tutorial. |
djrtwo
reviewed
Nov 22, 2021
|
|
||
| This type of test receives two parameters: | ||
|
|
||
| * `specs`: The protocol specifications |
There was a problem hiding this comment.
Suggested change
| * `specs`: The protocol specifications | |
| * `spec`: The protocol specification (constants, functions, object definitions, etc) |
tests/README.md
Outdated
|
|
||
| For every slot a validator is randomly selected as the proposer. Currently the proposer proposes the hash | ||
| for the current head of the beacon chain (the previous block). When shards are added, the proposer will also | ||
| propose a hash for the head of the assigned shard. |
There was a problem hiding this comment.
Suggested change
| propose a hash for the head of the assigned shard. |
There was a problem hiding this comment.
I would just cut out a lot of the sharding stuff. There are actually separate proposrs that build the shard chains and it's probably not worth getting in the nuance here.
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
djrtwo
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.