Update pow_chain
to dict and reuse it instead of calling get_pow_block
#2694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Per #2636 (comment) discussion:
If the validator already maintains all PoW blocks, they don't really have to call
get_pow_block(block.parent_hash)
(which we implied it's a JSON-RPC call) to get the parent block.How did I fix it
pow_chain
structure toDict[Hash32, PowBlock]
so that we can query the block by hash easily.parent = get_pow_block(block.parent_hash)
toparent = pow_chain[block.parent_hash]
.KeyError
is considered invalid.It turns out
get_terminal_pow_block
is much more concise with this change! ✨