--fork
cli option: fix the case of using pytest -k
without setting directory path
#2688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
--fork
isaction="append"
option without a single default value.request.config.getoption("--fork")
returnsNone
if directory path is set.request.config.getoption("--fork")
raisesValueError
if directory path is unset. (SomeAttributeError
in pytest internally)-k
AND without setting file or path, it raises error:p.s. Thank Ori and Danny for reporting it!
How did I fix it
This PR fixes this special case so that it will run tests against
ALL_FORKS
even if the directory path is unset.Also, this PR adds
_validate_fork_name
to verify if the given fork name is valid.Note: if anyone uses custom options without target file or directory path, it will raise errors. e.g.,
pytest -k test_slots_1 --bls-type milagro
is invalid.