base_fee_per_gas to uint256 #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discord discussion for reference: https://discord.com/channels/595666850260713488/692062809701482577/897205797002551336
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on some conversations on discord, we realized that the current little-endian 32-byte encoding of
base_fee_per_gasdoes not make too much sense.In practice, CL needs to convert this representation to an integer string for the engine API
engine_executePayload. Thus CL clients need to at least be able to parse/convert uint256 values regardless of whether we create the requirement to perform arithmetic on such big integer values.Note, all clients had to perform these types of conversions for the recent interop so they already can anyway. Plus this weird conversion gave some of them minor issues when getting up and running.
(thanks @potuz for bringing this back up and sparking the simplifying change)