initialize_beacon_state_from_eth1 for pre-transition merge #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
force-pushed
the
fix-merge-gen-state
branch
from
bea4b3c to
af262be
Compare
mkalinin
reviewed
Oct 3, 2021
djrtwo
force-pushed
the
fix-merge-gen-state
branch
from
6b95a5b to
34fd3ef
Compare
djrtwo
force-pushed
the
fix-merge-gen-state
branch
from
34fd3ef to
789eea0
Compare
hwwhww
reviewed
Oct 3, 2021
| @@ -17,7 +19,7 @@ def eth1_init_data(eth1_block_hash, eth1_timestamp): | |||
| } | |||
|
|
|||
|
|
|||
| @with_merge_and_later | |||
| @with_phases([MERGE]) | |||
There was a problem hiding this comment.
I changed it to @with_phases([MERGE]) because I think for the subsequent forks, the execution_payload_header field would be required?
There was a problem hiding this comment.
I personally think the transition logic might just stay in there, but we can debate it further down the line
hwwhww
force-pushed
the
fix-merge-gen-state
branch
from
dd82ba3 to
e235aa8
Compare
dapplion
reviewed
Oct 3, 2021
djrtwo
commented
Oct 4, 2021
| @@ -17,7 +19,7 @@ def eth1_init_data(eth1_block_hash, eth1_timestamp): | |||
| } | |||
|
|
|||
|
|
|||
| @with_merge_and_later | |||
| @with_phases([MERGE]) | |||
There was a problem hiding this comment.
I personally think the transition logic might just stay in there, but we can debate it further down the line
djrtwo
changed the title
Nashatyrev
reviewed
Oct 5, 2021
|
|
||
| ```python | ||
| def initialize_beacon_state_from_eth1(eth1_block_hash: Bytes32, | ||
| eth1_timestamp: uint64, | ||
| deposits: Sequence[Deposit]) -> BeaconState: | ||
| deposits: Sequence[Deposit], | ||
| execution_payload_header: ExecutionPayloadHeader=ExecutionPayloadHeader() |
There was a problem hiding this comment.
Why do we still need eth1_block_hash & eth1_timestamp? They should be both in the passed execution_payload_header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initialize_beacon_state_from_eth1on the Merge fork should work for two cases:(2) is very valuable for testnets that are built to test the merge transition logic
TODO: