Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ALTAIR_FORK_EPOCH for mainnet configuration #2625

Merged
merged 3 commits into from
Sep 27, 2021
Merged

add ALTAIR_FORK_EPOCH for mainnet configuration #2625

merged 3 commits into from
Sep 27, 2021

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Sep 24, 2021

Assuming no issues, this value for ALTAIR_FORK_EPOCH will be released in a v1.1.0 on Monday, Sept 27.

Rationale --

  • reasonable-ish time for most contributors (sorry California)
  • (ALTAIR_FORK_EPOCH * SLOTS_PER_EPOCH) % SLOTS_PER_HISTORICAL_ROOT == 0 -- thus types across forks for the batching are cleanly separated

@djrtwo djrtwo requested a review from protolambda September 24, 2021 18:18
configs/mainnet.yaml Outdated Show resolved Hide resolved
djrtwo and others added 2 commits September 24, 2021 12:28
Co-authored-by: terence tsao <terence@prysmaticlabs.com>
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢

@@ -29,7 +29,7 @@ GENESIS_DELAY: 604800

# Altair
ALTAIR_FORK_VERSION: 0x01000000
ALTAIR_FORK_EPOCH: 18446744073709551615
ALTAIR_FORK_EPOCH: 74240 # Oct 27, 2021, 10:56:23am UTC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sanity check: 1606824023+(74240*32*12)=1635332183, Wed Oct 27 2021 10:56:23 GMT+0000.
And extra: (74240*32)%(2**13)=0 (fresh block/state roots batch)

Copy link
Contributor

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for us! Should be included in Lighthouse v1.6.0 v2.0.0 later this week

bors bot pushed a commit to sigp/lighthouse that referenced this pull request Sep 27, 2021
## Proposed Changes

Schedule Altair on mainnet for epoch 74240 as per ethereum/consensus-specs#2625

This puts the date for Altair as Wed Oct 27 2021 10:56:23 GMT+0000
Copy link
Member

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lodestar 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants