Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version number in file name #26

Merged
merged 3 commits into from
Oct 3, 2018
Merged

Remove version number in file name #26

merged 3 commits into from
Oct 3, 2018

Conversation

JustinDrake
Copy link
Contributor

Putting the version number in the file name is not future proof

Putting the version number in the file name is not future proof
@hwwhww
Copy link
Contributor

hwwhww commented Oct 3, 2018

I think there will be more documents in /specs beside this one, so might more friendly to have a title in the file name. And it will be excellent if we can guarantee no more v2.2, v3. (fingers crossed)

@JustinDrake
Copy link
Contributor Author

We could remove version numbers altogether. It's a bit confusing to have "Ethereum 2.0" and "Spec version 2.1".

@djrtwo
Copy link
Contributor

djrtwo commented Oct 3, 2018

What about beacon-chain.md?

I think it best to not just be "spec" in the context of what will be a bunch of spec docs. It will also imply that we should put the shard chains spec in another doc.

Will also start updating the readme to link to various docs

@JustinDrake
Copy link
Contributor Author

A separate doc for the shards makes sense

@djrtwo
Copy link
Contributor

djrtwo commented Oct 3, 2018

handling merge conflict then merging

@djrtwo djrtwo merged commit d8afb92 into master Oct 3, 2018
@djrtwo djrtwo deleted the rename-file branch October 3, 2018 13:48
hwwhww pushed a commit that referenced this pull request Jul 23, 2020
hwwhww pushed a commit that referenced this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants