Update test_process_sync_aggregate.py #2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralexstokes
reviewed
Sep 2, 2021
There was a problem hiding this comment.
Nice catch!
I agree the spirit of this test is better expressed by just isolating the bad signature domain. We have other tests with bad bits so we are not losing any test coverage with this change.
I left one syntax suggestion -- the sync_committee_bits field is expecting a Sequence[bool] and it may work w/ a Sequence[int] but this would just be an idiosyncrasy of python and we can be clearing w/ explicit bool
...e/pyspec/eth2spec/test/altair/block_processing/sync_aggregate/test_process_sync_aggregate.py
Outdated
Show resolved
Hide resolved
…ggregate/test_process_sync_aggregate.py Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
djrtwo
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_invalid_signature_bad_domainis about testing bad domain . There is a little copy/cargo issue withtest_invalid_signature_missing_participant