Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testing helper process_and_sign_block_without_header_validations #2579

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Fix testing helper process_and_sign_block_without_header_validations #2579

merged 1 commit into from
Sep 7, 2021

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Aug 31, 2021 •
edited
Loading

Issue

process_block function was updated in Altair and The Merge. Thus this testing helper should be updated too.

Proposed solution

  1. Add the missing steps into process_and_sign_block_without_header_validations
  2. To make process_execution_payload pass, fill body.execution_payload if it needs.

djrtwo
djrtwo reviewed Sep 1, 2021
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct

Were we building incorrect blocks that were more messed up than we inteded?

@hwwhww
Copy link
Contributor Author

hwwhww commented Sep 2, 2021

@djrtwo

Were we building incorrect blocks that were more messed up than we inteded?

Yes, we were. 😅

@djrtwo djrtwo merged commit ccd48d7 into dev Sep 7, 2021
@djrtwo djrtwo deleted the fix-process_and_sign_block_without_header_validations branch September 7, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwwhww @djrtwo