Allow spec tests author to batch tests under one handler name #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
reviewed
Aug 30, 2021
djrtwo
approved these changes
Sep 1, 2021
There was a problem hiding this comment.
looks good. spoke with @ralexstokes out of band and agreed there is value in splitting out "sanity" and "random" block tests especially for new clients coming online
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request from implementation teams to batch "like-operations" when generating consensus spec tests.
The test generation infra followed the file tree of the test repo to determine the organization of the output test data.
This PR allows a test author to batch tests under one handler name, regardless of file tree layout, by providing a list of "like" test modules, rather than just a single
strof the module name.This PR also adds a "collect" mode to the test generation infra (like the
pytestcollection phase), used to verify we pulled the same number of tests with this change.