Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for exited validators during inactivity leak #2542

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Add test for exited validators during inactivity leak #2542

merged 3 commits into from
Aug 6, 2021

Conversation

ralexstokes
Copy link
Member

Adds a spec test for the concrete bug found while debugging #2541.

Does not add any extensive validator lifecycle testing as referenced in that issue but the debugging did reveal a hole in our spec testing coverage which this PR aims to fix.

Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of nits and a question

ralexstokes and others added 2 commits August 5, 2021 16:54
…rocess_inactivity_updates.py

Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
…rocess_inactivity_updates.py

Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@djrtwo djrtwo merged commit b184fa2 into ethereum:dev Aug 6, 2021
@ralexstokes ralexstokes deleted the add-inactivity-updates-test-with-exited-validator branch August 6, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants