Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for SyncAggregate with no participants and all zero signature #2523

Merged
merged 3 commits into from
Jul 17, 2021

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Jul 17, 2021

Adds a test for SyncAggregate processing where there are no participants and the signature is all zeros instead of the infinite point.
Also a test for the infinite signature when there are participants.

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a few minor changes, I'll update this PR, looks good otherwise 👍

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@protolambda protolambda merged commit 4c04090 into ethereum:dev Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants