Add randomized testing for Altair process_sync_aggregate
#2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralexstokes
commented
Jul 7, 2021
| @@ -206,7 +210,6 @@ def test_sync_committee_rewards_duplicate_committee_no_participation(spec, state | |||
| committee_indices = get_committee_indices(spec, state, duplicates=True) | |||
| committee_size = len(committee_indices) | |||
| committee_bits = [False] * committee_size | |||
| assert len(committee_bits) == committee_size | |||
There was a problem hiding this comment.
this likely got copied from another test where it was more important to check the committee size; however, there is no manipulation of this set here so we just remove the assert
djrtwo
approved these changes
Jul 7, 2021
tests/core/pyspec/eth2spec/test/altair/block_processing/test_process_sync_aggregate.py
Outdated
Show resolved
Hide resolved
tests/core/pyspec/eth2spec/test/altair/block_processing/test_process_sync_aggregate.py
Outdated
Show resolved
Hide resolved
tests/core/pyspec/eth2spec/test/altair/block_processing/test_process_sync_aggregate.py
Outdated
Show resolved
Hide resolved
tests/core/pyspec/eth2spec/test/altair/block_processing/test_process_sync_aggregate.py
Outdated
Show resolved
Hide resolved
tests/core/pyspec/eth2spec/test/altair/block_processing/test_process_sync_aggregate.py
Outdated
Show resolved
Hide resolved
tests/core/pyspec/eth2spec/test/altair/block_processing/test_process_sync_aggregate.py
Outdated
Show resolved
Hide resolved
tests/core/pyspec/eth2spec/test/altair/block_processing/test_process_sync_aggregate.py
Outdated
Show resolved
Hide resolved
tests/core/pyspec/eth2spec/test/altair/block_processing/test_process_sync_aggregate.py
Outdated
Show resolved
Hide resolved
tests/core/pyspec/eth2spec/test/altair/block_processing/test_process_sync_aggregate.py
Outdated
Show resolved
Hide resolved
tests/core/pyspec/eth2spec/test/altair/block_processing/test_process_sync_aggregate.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some randomized testing for sync aggregate processing.
The following test cases are added for both committees with duplicated indices and committees without duplicated indices.
NOTE: the cases of 0% participation and 100% participation are already covered by existing tests (however, they all use the same rng seed)