Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the constants for readability #25

Merged
merged 3 commits into from
Oct 3, 2018
Merged

Conversation

JustinDrake
Copy link
Contributor

No description provided.

| `MIN_DYNASTY_LENGTH` | 2**8 (= 256) | slots | ~1.1 hours |
| `SQRT_E_DROP_TIME` | 2**16 (= 65,536) | slots | ~12 days |
| `WITHDRAWAL_PERIOD` | 2**19 (= 524,288) | slots | ~97 days |
| `BASE_REWARD_QUOTIENT` | 2**15 (= 32,76) | — |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: 2**15 (= 32,76) -> 2**15 (= 32,768)

@djrtwo
Copy link
Contributor

djrtwo commented Oct 3, 2018

Handled merge conflict. Changes look good. merging!

@djrtwo djrtwo merged commit f6c1b6c into master Oct 3, 2018
@djrtwo djrtwo deleted the constants-readability branch October 3, 2018 13:31
hwwhww pushed a commit that referenced this pull request Jul 23, 2020
Also use python:3.8.1 docker image.
hwwhww pushed a commit that referenced this pull request Jul 23, 2020
Also use python:3.8.1 docker image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants