Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message.topic to gossipsub message-id in Altair #2475

Merged
merged 4 commits into from
Jun 8, 2021
Merged

Add message.topic to gossipsub message-id in Altair #2475

merged 4 commits into from
Jun 8, 2021

Conversation

ralexstokes
Copy link
Member

Fixes #2471.

In lieu of discriminating duplicated sync committee messages as suggested in #2471 by adding the subnet_id to the message itself, this PR suggests a solution by incorporating the topic name in to the gossipsub message-id. This solution should allow sync committee message duplicates to still remain distinct in the gossipsub machinery without needing to add an additional field to the message type.

Per discussion w/ @djrtwo and @protolambda, this avoids a potential DoS vector w/ the additional (unsigned) field and should harden message propagation across fork boundaries (as the fork digest will enter via the message.topic). This solution should also be a bit less intrusive than changing the sync committee structures further. Obviously open to other alternatives discovered during implementation :)

Co-authored-by: Diederik Loerakker <proto@protolambda.com>
@protolambda
Copy link
Contributor

Hmm, I think we should clarify the transition process of the message ID. For altair it won't matter, but it has to happen all at the same time, or we get two different message IDs for the same message. With altair we drop all old topic names anyway, so I suppose that we just never use the new message ID function for old topics?

@protolambda protolambda merged commit 8f8b5ab into ethereum:dev Jun 8, 2021
@ralexstokes ralexstokes deleted the discriminate-sync-comm-msg branch June 11, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't publish SyncCommitteeSignature to multiple subnets
3 participants