[Sharding] Handle the case when committee count < active shards #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Block is invalid if contains ShardBlobHeader lacking committee Reject Gossip ShardBlobHeader and ShardBlob messages which lacks committee
Nashatyrev
commented
May 27, 2021
specs/sharding/beacon-chain.md
Outdated
Comment on lines
705
to
707
| if index is None: | ||
| # the shard had no committee on this slot | ||
| continue |
There was a problem hiding this comment.
Another approach could be iterating through committees instead of shards.
|
I think we can drop the beacon-chain doc part of the changes, thanks to the improved state format (PR #2455, thanks for the original idea). But the p2p changes still make sense. Can you separate those out? |
…-case # Conflicts: # specs/sharding/p2p-interface.md
…he `compute_committee_index_from_shard` raises an error if no committee assigned to a shard
|
Rebased this PR on top of #2455:
|
protolambda
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShardBlobHeaderlacking committeeShardBlobHeaderandShardBlobmessages which lacks committee