Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Altair fork tests to test generators #2427

Merged
merged 1 commit into from
May 19, 2021
Merged

Add Altair fork tests to test generators #2427

merged 1 commit into from
May 19, 2021

Conversation

ralexstokes
Copy link
Member

A few fixes for the fork tests in Altair.

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented the same fixes in #2390 when updating test generation for new config usage, I wasn't aware of the problem in dev. LGTM.

Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

I used this fix in the tarball generation for the alpha.5 test vectors

@djrtwo djrtwo merged commit e384686 into ethereum:dev May 19, 2021
@ralexstokes ralexstokes deleted the fix-altair-fork-unit-tests branch May 20, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants