Altair review #2374
Merged
Altair review #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protolambda
reviewed
May 4, 2021
ralexstokes
approved these changes
May 4, 2021
| @@ -311,10 +320,17 @@ def get_base_reward_per_increment(state: BeaconState) -> Gwei: | |||
|
|
|||
| #### `get_base_reward` | |||
|
|
|||
| *Note*: The function `get_base_reward` is modified with the removal of `BASE_REWARDS_PER_EPOCH`. | |||
| *Note*: The function `get_base_reward` is modified with the removal of `BASE_REWARDS_PER_EPOCH` and the use of increment based accounting. | |||
There was a problem hiding this comment.
tbh i'm not really sure what "increment based" means but i don't think it blocks this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_{attestation_field}as having to have the parentis_{attestation_field}correct, thus enforcing chain coherence any time those booleans are used