[Sharding] Fix unspecified SHARD_COUNT and DOMAIN_SHARD_HEADER constants #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protolambda
reviewed
May 4, 2021
| @@ -718,9 +718,10 @@ def charge_confirmed_header_fees(state: BeaconState) -> None: | |||
| get_active_shard_count(state, get_current_epoch(state)) | |||
| * SLOTS_PER_EPOCH * GASPRICE_ADJUSTMENT_COEFFICIENT | |||
| ) | |||
| previous_epoch_start_slot = compute_start_slot_at_epoch(get_previous_epoch(state)) | |||
| previous_epoch = get_previous_epoch(state) | |||
| previous_epoch_start_slot = compute_start_slot_at_epoch(previous_epoch) | |||
There was a problem hiding this comment.
Good fix, but this reminds me we should limit some of these methods to epoch 1+, epoch 0 doesn't work quite as expected. The previous epoch var would be clipped to 0, and then it tries to confirm current-epoch shard headers.
protolambda
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOMAIN_SHARD_HEADERconst withDOMAIN_SHARD_PROPOSERSHARD_COUNTconst withget_active_shard_count(previous_epoch)incharge_confirmed_header_feesSHARD_COUNTwithMAX_SHARDSwhen clearinggrandparent_epoch_confirmed_commitmentswith default valuesFix #2357