Fix: pass Set instead of Sequence to get_total_balance #2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be of `Set[ValidatorIndex]` type, however, `Sequence` is passed
protolambda
approved these changes
Apr 26, 2021
| @@ -539,7 +539,7 @@ def update_pending_votes(state: BeaconState, attestation: Attestation) -> None: | |||
| participants = get_attesting_indices(state, attestation.data, pending_header.votes) | |||
| participants_balance = get_total_balance(state, participants) | |||
| full_committee = get_beacon_committee(state, attestation.data.slot, attestation.data.index) | |||
| full_committee_balance = get_total_balance(state, full_committee) | |||
| full_committee_balance = get_total_balance(state, set(full_committee)) | |||
There was a problem hiding this comment.
Maybe we should introduce some type for an ordered-set in the spec. The committee members each have an index, and are unique, at the same time. The total-balance computation is order-independent though, so a set is fine here.
ericsson49
deleted the
ericsson49/fix_pass_set_instead_of_sequence_to_get_total_balance
branch
ericsson49
restored the
ericsson49/fix_pass_set_instead_of_sequence_to_get_total_balance
branch
ericsson49
deleted the
ericsson49/fix_pass_set_instead_of_sequence_to_get_total_balance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed typing problem in
process_pending_headersand inupdate_pending_votes:Sequence[ValidatorIndex]passed instead ofSet[ValidatorIndex].In both cases the collection of indices passed to
get_total_balanceoriginates fromget_beacon_committee: either filtered (process_pending_headers) or "as is" (update_pending_votes).That means there should be no duplicates, if there is no duplicates in the
get_beacon_committeeresult. So, converting toSetshouldn't affect result.