Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More typos fixes in sharding #2358

Merged

Conversation

ericsson49
Copy link
Contributor

@ericsson49 ericsson49 commented Apr 23, 2021

Fixed typos in the methods:

  • process_shard_header:
    • body_summary missed when accessingShardBlobBodySummary.beacon_block_root
  • process_pending_headers
    • c variable name used instead of header
  • charge_confirmed_header_fees:
    • get_shard_proposer used instead of get_shard_proposer_index
  • reset_pending_headers
    • SLOTS_IN_EPOCH used instead of SLOTS_PER_EPOCH
    • state missed in get_committee_count_per_slot(next_epoch) call
  • process_epoch
    • process_confirmed_header_fees called instead of charge_confirmed_header_fees

@ericsson49 ericsson49 changed the title Fix typo in process_shard_header More typos fixes in sharding Apr 24, 2021
@protolambda protolambda added the scope:sharding Sharding label Apr 26, 2021
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We will make this part of the spec executable in a week or two, and run some tests and linting, to try and catch things like this.

@protolambda protolambda merged commit fd9c96d into ethereum:dev Apr 26, 2021
@ericsson49 ericsson49 deleted the ericsson49/fix_process_shard_header branch April 26, 2021 18:44
@ericsson49 ericsson49 restored the ericsson49/fix_process_shard_header branch April 27, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants