Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos in sharding #2356

Merged
merged 1 commit into from
Apr 26, 2021
Merged

fix typos in sharding #2356

merged 1 commit into from
Apr 26, 2021

Conversation

ericsson49
Copy link
Contributor

Two typing problems fixed:

  • next_power_of_two has no type annotations
  • compute_proposer_index references GWei

ralexstokes
ralexstokes approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@djrtwo djrtwo merged commit fa24867 into ethereum:dev Apr 26, 2021
@ericsson49 ericsson49 deleted the ericsson49/fix_typos_in_sharding branch April 26, 2021 18:43
@ericsson49 ericsson49 restored the ericsson49/fix_typos_in_sharding branch April 27, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexstokes ralexstokes ralexstokes approved these changes

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericsson49 @djrtwo @ralexstokes