Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add always_bls for historical batch sanity test #2344

Merged
merged 1 commit into from
Apr 21, 2021
Merged

add always_bls for historical batch sanity test #2344

merged 1 commit into from
Apr 21, 2021

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Apr 20, 2021

fixes #2335

Because the historical batch and sync committee periods are equal in length, we must do bls processing during this epoch transition integration test to ensure committees are calculated properly.

Note: this is not the case for unit tests that only test process_historical_roots_update

@djrtwo djrtwo requested a review from hwwhww April 20, 2021 19:44
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djrtwo djrtwo merged commit f7cc6fe into dev Apr 21, 2021
@djrtwo djrtwo deleted the hist-test branch April 21, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Altair sanity blocks test missing BLS setting
2 participants