Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch test_filtered_block_tree test generator #2272

Merged
merged 1 commit into from
Mar 25, 2021
Merged

patch test_filtered_block_tree test generator #2272

merged 1 commit into from
Mar 25, 2021

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Mar 24, 2021

address #2269

note, we could just yield with extraneous checks because there is no update but it also makes it a bit clearer to test writers what is being checked after adding all the blocks.

thanks @ajsutton!

@djrtwo djrtwo requested a review from hwwhww March 24, 2021 18:59
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, that was my dumb typo 🙈

Thank you @ajsutton @djrtwo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants