reduce justification and finalization Altair diff #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protolambda
added
general:presentation
djrtwo
approved these changes
Mar 22, 2021
djrtwo
force-pushed
the
justification-altair
branch
from
287b4b2 to
bb85ef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes, just presentation:
process_justification_and_finalizationinto calculation of target stake andweigh_justification_and_finalizationto consider the stake totals and update state.weigh_justification_and_finalizationThis helps reduce the diff, avoids duplicate code, and improves the performance of the spec implementation (
get_total_active_balance(state)only has to be called once).Suggestions for variable and function naming welcome.