Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert local config settings from .gitignore #1902

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Jun 16, 2020

Some local setup files (rather than specific to general operation of the repo) were added in #1705.

I would argue that these should go into the local system's global gitignore rather than the repo here

@djrtwo
Copy link
Contributor Author

djrtwo commented Jun 16, 2020

cc: @dankrad

@dankrad
Copy link
Contributor

dankrad commented Jun 17, 2020

There seem to be some other only locally relevant entries in there. But sure I can set these locally.

@djrtwo
Copy link
Contributor Author

djrtwo commented Jun 18, 2020

I think the only local config items in there might be the different naming conventions for venv. Other than that, all of those items can and do appear in the normal build and test processes

@djrtwo djrtwo requested a review from hwwhww June 18, 2020 15:13
@hwwhww hwwhww merged commit 398ad99 into dev Jun 18, 2020
@hwwhww hwwhww deleted the repo-specific-gitignore branch June 18, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants