Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clarifying note about attnets ENR entry #1775

Merged
merged 1 commit into from
Apr 30, 2020
Merged

add clarifying note about attnets ENR entry #1775

merged 1 commit into from
Apr 30, 2020

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Apr 30, 2020

Prysm was updating attnets at each epoch based on beacon committee assignments. This is not needed and might actually be harmful in finding stable peers at the right time.

Added a quick clarifying note to the val-guide

addresses #1774
thanks @jrhea for finding this in prysm!

@djrtwo djrtwo requested a review from hwwhww April 30, 2020 02:31
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jrhea :)

@q9f
Copy link
Contributor

q9f commented Apr 30, 2020

👍 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants