Reorder block gossip conditions #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorder block gossip conditions based on convo with @paulhauner
Check the signature wrt
block.proposer_indexbefore checking that the proposer is the expected proposer for the slot. This limits the scope of DoS to other validators rather than to the entire world.Keep the optional "MAY" on queuing a block to investigate proper shuffling in case that a cartel of proposers goes rogue and starts the N-1 per slot block DoS vector. Cool thing here is that if a cartel does abuse this, we can (out of band) figure it out and fight back