validate block slot not from future in gossip #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
changed the title
djrtwo
force-pushed
the
p2p-validate-block-slot
branch
3 times, most recently
from
9588d3d to
aecfa5e
Compare
protolambda
reviewed
Jan 10, 2020
djrtwo
force-pushed
the
p2p-validate-block-slot
branch
from
8ab0852 to
5e96c08
Compare
protolambda
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
beacon_blockgossip channel to prevent blocks from be gossiped from the future.MAXIMUM_GOSSIP_CLOCK_DISPARITYto allow for some assumed clock disparity when gossiping messagesSignedVoluntaryExit(rather thanVoluntaryExit)Discussion:
compute_slot_at_epoch(latest_finalized_epoch) < block.slot <= current_slot)