fix default value when voting on eth1data #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
force-pushed
the
eth1-default-bug
branch
3 times, most recently
from
681b755 to
3a67380
Compare
djrtwo
force-pushed
the
eth1-default-bug
branch
from
3a67380 to
b8d4ce4
Compare
protolambda
approved these changes
Jan 9, 2020
djrtwo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @cemozerr for finding and reporting this.
If the eth1 chain is live and well connected, the validator votes on the 0th block in the acceptable voting period when no other valid votes already exist.
If the eth1 chain is not live, the validator defaults to voting on the previous eth1data which is a no-op