Tests based on K cov from #1420, updated to get into v08x before release. #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring going on on line `if a.data.target.root == get_block_root(state, epoch)`. Discovered by K coverage tool.
…sits don't contribute to active balance.
…lidator_indices in get_attestation_deltas() != state.validators. In this test some validators were just never active.
…tations are slashed. Modifies attesting_balance and consequently rewards/penalties.
djrtwo
approved these changes
Oct 24, 2019
...pyspec/eth2spec/test/phase_0/epoch_processing/test_process_justification_and_finalization.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1420
This PR includes the suggested code de-duplication, a few minor fixes, and only enables a new minimal-mode generator, as the mainnet mode for it is not fast enough yet (full filled 64-slot long epochs are too heavy for unoptimized pyspec)