merkle proofs: Fix get_helper_indices #1423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
get_helper_indices
will include unneeded indices if both direct children are not included in the proof (either as leaves or helpers/sisters).eg:
get_helper_indices([8,9,10,11,12])
should return[13, 7]
, but returns[13, 7, 3]
3 is unnecessary b/c it can be computed from 12, 13, 7.
Instead of only looking at direct children, all helper indices in a leaf -> root path should be filtered out, since any indices in a path can always be computed with a valid proof.