SSZ clarifications on deserialization #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrChico
reviewed
Sep 26, 2019
|
Fixed the typo, and changed the end-bit description for bitlists: it is confusing to say |
protolambda
approved these changes
Oct 25, 2019
There was a problem hiding this comment.
There are plans to move out the SSZ spec description, and better explain the finer details for implementers. However, I do think it is useful to include this PR and see how it is received by implementers, to improve the SSZ spec in the future based on their feedback.
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to close #1359.
Also replaced the confusing "leading bit" terminology for bitlists