Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.8.3 to master #1375

Merged
merged 18 commits into from
Aug 23, 2019
Merged

Release v0.8.3 to master #1375

merged 18 commits into from
Aug 23, 2019

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Aug 22, 2019

Detailed changelog to accompany release

@djrtwo djrtwo requested review from protolambda and hwwhww August 22, 2019 22:23
hwwhww
hwwhww approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@djrtwo djrtwo mentioned this pull request Aug 23, 2019
Merged
protolambda
protolambda approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lightclient and others added 18 commits August 23, 2019 18:31
@lightclient @protolambda
Improve readability of SSZ type defaults
520c872
@protolambda
make nil-count randomization work for lists
4f462bc
@arnetheduck @protolambda
Update libp2p networking spec
a8ac4d6
@raulk @protolambda
add table of contents; amend heading level.
4bae9b4
@raulk @protolambda
gossip domain: clarify why we use plaintext topic names.
aa28592
@raulk @protolambda
document doctoc command for posterity.
e81629d
@raulk @protolambda
fmt.
26d342e
@raulk @hwwhww
@prestonvanloon @protolambda
apply editorial suggestions.
e147684 
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
Co-Authored-By: Preston Van Loon <preston@prysmaticlabs.com>
@raulk @hwwhww @protolambda
apply more editorial suggestions.
d0e1f29 
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
@arnetheduck @protolambda
Updates
26ea675 
* constants -> configurations
* constant name updates
* initial validation requirement for attestations
* allow aggregated attestations to be published
* move discv5 down a bit
* additional rationale
@arnetheduck @protolambda
cleanups
f0ce20b
@arnetheduck @protolambda
discuss length-prefixing pro/con, consider for removal, add link
94d2368
@JSON @hwwhww @protolambda
doc standardization for networking spec (#1338)
dee70df 
* Update p2p-interface.md

* Update p2p-interface.md

* Update p2p-interface.md

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>

* Update specs/networking/p2p-interface.md

Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
@AgeManning @protolambda
Minor corrections and clarifications to the network specification
194f292
@djrtwo @protolambda
minor formatting
f62aede
@protolambda
Fix ssz-generic bitvector tests: those invalid cases of higher length…
4283c8c 
… than type describes, but same byte size, should have at least 1 bit set in the overflow to be invalid
@djrtwo @protolambda
add note on local aggregation for interop
0547d0c
@djrtwo @protolambda
Update specs/networking/p2p-interface.md
3d97160 
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
@protolambda
Copy link
Contributor

Invalid signature on cosmetic commit by @lightclient, reason as stated by Matt:

I saw that 😔 the issue was that I signed that commit when my username was c-o-l-o-r and I use the private github email for commits to avoid leaking my personal email — problem is, when you change your username a new private email address is generated for the account, so that broke the relation to that signature and my account email

Rebased and signed it.

@djrtwo djrtwo merged commit af30324 into master Aug 23, 2019
@djrtwo djrtwo deleted the v08x branch September 7, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@djrtwo @protolambda @hwwhww @lightclient @arnetheduck @raulk @JSON @AgeManning