Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove light client infrastructure from phase 0 #1329

Merged
merged 4 commits into from
Aug 23, 2019
Merged

Remove light client infrastructure from phase 0 #1329

merged 4 commits into from
Aug 23, 2019

Conversation

JustinDrake
Copy link
Contributor

@JustinDrake JustinDrake commented Aug 1, 2019

Remove light client infrastructure (active index roots and crosslink committee roots) from phase 0. Alternative infrastructure (namely, persistent committee roots) will be added in phase 1 for light clients (following an improved design). Benefits:

  • Significantly less hashing for the beacon chain (persistent committee roots are relatively rarely updated)
  • Code simplification (40 lines removed)
  • Conceptual cleanup with all light client infrastructure in phase 1

@JustinDrake JustinDrake added scope:light-clients post-freeze (substantive) Substantive consensus change non-critical for long-lived cross-client testnets labels Aug 1, 2019
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍
Note that #1316 needs some updates once this PR has been merged.

@vbuterin
Copy link
Contributor

vbuterin commented Aug 6, 2019

Does it? AFAIK the light client PR only uses the added logic in #1323.

@hwwhww
Copy link
Contributor

hwwhww commented Aug 16, 2019

@vbuterin we will have to copy the definition of CompactCommittee to #1316 if #1329 gets merged first.

class CompactCommittee(Container):
    pubkeys: List[BLSPubkey, MAX_VALIDATORS_PER_COMMITTEE]
    compact_validators: List[uint64, MAX_VALIDATORS_PER_COMMITTEE]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
post-freeze (substantive) Substantive consensus change non-critical for long-lived cross-client testnets scope:light-clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants