Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] bump py_ecc==1.7.1 #1300

Merged
merged 1 commit into from
Jul 16, 2019
Merged

[hotfix] bump py_ecc==1.7.1 #1300

merged 1 commit into from
Jul 16, 2019

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Jul 16, 2019

Issue

The new release of py_ecc includes #1246 changes and its not backward compatible, that's why pyspec is broken with the current dependency py_ecc>=1.6.0.

Proposing solution

  1. Pin py_ecc==1.7.1
  2. Update both pyspec and BLS test generator's domain type.
  3. Minor refactoring of BLS test generator

@djrtwo it needs to backport to dev branch soon.

2**64-1
b'\x00\x00\x00\x00\x00\x00\x00\x00',
b'\x00\x00\x00\x00\x00\x00\x00\x01',
b'\xff\xff\xff\xff\xff\xff\xff\xff'
Copy link
Contributor Author

@hwwhww hwwhww Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for the reviewers: I changed the testing input here.

@djrtwo djrtwo merged commit 7bc4fb6 into v08x Jul 16, 2019
@djrtwo djrtwo deleted the new_py_ecc_domain branch July 16, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants