Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Bitlist/Bitvector serialization using bytes, not bigints #1267

Merged
merged 4 commits into from
Jul 14, 2019

Conversation

dankrad
Copy link
Contributor

@dankrad dankrad commented Jul 3, 2019

This does not change any logic and the serialization and Merkleization is exactly as before, but now defined using byte operations instead of bigints.

@JustinDrake JustinDrake added the general:presentation Presentation (as opposed to content) label Jul 3, 2019
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
@hwwhww
Copy link
Contributor

hwwhww commented Jul 4, 2019

@dankrad
also need to update the SSZ spec doc as well. :)

@hwwhww hwwhww added the scope:SSZ Simple Serialize label Jul 4, 2019
@hwwhww hwwhww changed the base branch from dev to v08x July 4, 2019 09:37
@protolambda
Copy link
Contributor

It looked like this PR was stuck, so I updated it.

  • reduced the code duplication with an .as_bytes() in the pyspec implementation
  • updated the ssz spec doc to also directly go from bits to bytes (instead of intermediate as_integer)

@dankrad a review back is welcome :)

@protolambda
Copy link
Contributor

Also: the merkleization part is cleaned up in #1292, along with other merkleization wording/implementation fixes

@djrtwo djrtwo merged commit 77f007c into v08x Jul 14, 2019
@djrtwo djrtwo deleted the dankrad-patch-9 branch July 14, 2019 23:20
@ralexstokes ralexstokes mentioned this pull request Jul 15, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general:presentation Presentation (as opposed to content) scope:SSZ Simple Serialize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants