-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helpers cleanup #1237
Helpers cleanup #1237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a much more sensible ordering of helpers, I really like it! I do have a few comments though:
- For consistency's sake, I think the
Terminology
section should be removed from1_custody.md
too. - I am not a fan of the function naming used in the
Misc
section of0_beacon_chain.md
. Based on the name alone, I don't think I would be able to determine what a function does in many of the cases. See my individual comments for details. If you are averse to the use ofget
in function names in this section, what about usingcompute
orcalculate
instead (this is already done incompute_committee
).
I tried making |
I think we should leave as is instead of the "default" value here. It is a configurable constant that might be changed in the future (or in different deployments) |
I'd prefer to revert to my last commit and get this merged. We have other things to handle that are waiting on this PR |
That's fine :) (Tried moving it to see if spec builder would be happier.) Making it |
Addresses #918. It includes: