Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage improvements #1206

Merged
merged 49 commits into from
Jun 29, 2019
Merged

Test coverage improvements #1206

merged 49 commits into from
Jun 29, 2019

Conversation

protolambda
Copy link
Contributor

Spec-tests improvements, with the aim to provide a more complete suite of spec-test-vectors.

See issue #1200 for tracking progress.

@protolambda protolambda added scope:CI/tests/pyspec milestone:June 30 freeze 🥶 Phase 0 spec freeze for long-lived cross-client testnet labels Jun 22, 2019
djrtwo
djrtwo reviewed Jun 24, 2019
View reviewed changes
test_libs/pyspec/eth2spec/test/phase_0/block_processing/test_process_attestation.py Outdated Show resolved Hide resolved
test_libs/pyspec/eth2spec/test/phase_0/block_processing/test_process_attester_slashing.py Outdated Show resolved Hide resolved
test_libs/pyspec/eth2spec/test/phase_0/block_processing/test_process_attester_slashing.py Outdated Show resolved Hide resolved
test_libs/pyspec/eth2spec/test/phase_0/block_processing/test_process_deposit.py Outdated Show resolved Hide resolved
test_libs/pyspec/eth2spec/test/phase_0/block_processing/test_process_transfer.py Show resolved Hide resolved
test_libs/pyspec/eth2spec/test/phase_0/block_processing/test_process_transfer.py Show resolved Hide resolved
test_libs/pyspec/eth2spec/test/sanity/test_blocks.py Outdated Show resolved Hide resolved
@protolambda protolambda force-pushed the cov-hunt branch 3 times, most recently from 813f0d6 to 4cba3dc Compare June 25, 2019 02:52
protolambda and others added 20 commits June 26, 2019 22:11
@protolambda
Eth1 data test
b133ded
@protolambda
eth1 voting no consensus test
f54d1a5
@protolambda
sign blocks in eth1 vote tests
13b67b4
@protolambda
test invalid shard in attestation
3279538
@protolambda
test old and future target epoch in attestation
f75e3dc
@protolambda
improve intersection test, just 1 index is enough. And add invalid at…
64e15c5 
…t1/att2 tests
@protolambda
expected deposit count test
1d6b1ca
@protolambda
effective balance testing in deposits
55d86b4
@protolambda
Bugfix transfer tests
063d94b
@protolambda
non-existent transfer participants tests
e79b47e
@protolambda @djrtwo
rename test methods based on suggestion
6266133 
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
@protolambda
different new-deposit tests
c4b88e6
@protolambda
test activation queue
b4b4e95
@protolambda
fix transfer tests, add 2 new tests
0e3c2ce
@protolambda
generalize epoch processing testing, add final-processing tests
b2034a5
@protolambda
test_eth1_vote_no_reset
c4c9bd3
@protolambda
clean up epoch processing testing
aedd281
@protolambda
fix crosslink tests, fix generalization of epoch processing
c66031f
@protolambda
detach crosslink tests from extra block
46dc3f3
@protolambda
new process-slashings tests, and epoch processing bugfix with transit…
24aa064 
…ion-to-excl not working when not yielded from
protolambda and others added 18 commits June 29, 2019 02:30
@protolambda
Merge branch 'dev' into cov-hunt
d31f1b2
@protolambda
fix attestation tests to work with checkpoints
518db42
@protolambda
update attester slashings processing tests
efd9d17
@protolambda
fix broken block test for checkpoint use
afb34c7
@protolambda
finalization testing
cfbdee7
@djrtwo
some fixes to finality_12
f484b1e
@djrtwo
fix source/target epochs in test_12
1885e28
@djrtwo
aggregation_bitfield - bits
bc5e947
@djrtwo
fix source/target
022f1e7
@djrtwo
add shard to mock crosslink to separate attestations from eachother
129fd62
@CarlBeek
Fix list slicing
b05bebf
@CarlBeek
Fix 123 finalisation
f9ca7c9
@CarlBeek
Corrects justification comments
2eca6ef
@CarlBeek
Makes justification ratios more marginal
0680d8c
@CarlBeek
mock attestation refactor
4ed7af7
@CarlBeek
Finnish refactor
0c29c51
@protolambda
bugfix attestation creation so that it works on mainnet with multiple…
5d633bf 
… committees per slot, and improve bitfield index descriptions
@protolambda
Merge pull request #1228 from ethereum/cov-hunt-fix-ish
b0510fe 
Some fixes to finality tests
@djrtwo
Copy link
Contributor

djrtwo commented Jun 29, 2019

awesome!

@protolambda
Copy link
Contributor Author

Validated all bls-supporting tests to pass with BLS on.
Except fork choice tests, which erroneously declare test cases to pass, but fork-choice is also not for generators yet, as it doesn't yield any information to the runner. Also not part of this PR really.

So we can merge this PR if we are done with code review :)

@protolambda protolambda marked this pull request as ready for review June 29, 2019 21:00
djrtwo
djrtwo approved these changes Jun 29, 2019
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very exciting. great work @protolambda!

@djrtwo djrtwo merged commit 34ad123 into dev Jun 29, 2019
@djrtwo djrtwo deleted the cov-hunt branch June 29, 2019 21:09
@JustinDrake JustinDrake mentioned this pull request Jun 29, 2019
Closed
41 tasks
@hwwhww hwwhww mentioned this pull request Jul 5, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
milestone:June 30 freeze 🥶 Phase 0 spec freeze for long-lived cross-client testnet scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@protolambda @djrtwo @CarlBeek