Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase historical length and cleanups #1196

Merged
merged 3 commits into from
Jun 19, 2019
Merged

Increase historical length and cleanups #1196

merged 3 commits into from
Jun 19, 2019

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Jun 19, 2019 •
edited
Loading

[port of #1109. PR was stale and rewrite was easier than merge]

  • Address item 11 of Phase 0 state transition checklist—take 5 #1054. This stores 8-month old historical start shards so that historical committees to be recomputed (e.g. for attester slashings).
  • collapse ACTIVE_INDEX_ROOTS_LENGTH and RANDAO_MIXES_LENGTH into single var -- HISTORICAL_VECTOR_LENGTH
  • some minor cleanups

@djrtwo djrtwo mentioned this pull request Jun 19, 2019
Closed
@JustinDrake JustinDrake merged commit 29dbe1b into dev Jun 19, 2019
CarlBeek added a commit that referenced this pull request Jun 19, 2019
@CarlBeek
Merge branch 'dev' into executable_fork_choice
e0d814d 
* dev:
  Increase historical length and cleanups (#1196)
@djrtwo djrtwo deleted the increase-historical-length branch June 20, 2019 15:41
This was referenced Jun 24, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinDrake JustinDrake JustinDrake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djrtwo @JustinDrake