Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1146 block state root issue #1177

Merged
merged 2 commits into from
Jun 14, 2019
Merged

Fix #1146 block state root issue #1177

merged 2 commits into from
Jun 14, 2019

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Jun 14, 2019 •
edited
Loading

Addresses #1146
Add function state_transition_and_sign_block to tests that both performs a state transition and properly formats the block by inserting the post state root and signing.

Considering renaming state_transition_and_sign_block to state_transition_and_package_block

@djrtwo djrtwo changed the base branch from dev to v07x June 14, 2019 00:02
@djrtwo djrtwo requested a review from protolambda June 14, 2019 00:05
protolambda
protolambda approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

state_transition_and_sign_block looks ok to me, no need to rename. lgtm.

@protolambda protolambda merged commit 7cf0dcd into v07x Jun 14, 2019
@protolambda protolambda deleted the block-state-root-fix branch June 14, 2019 00:47
@djrtwo djrtwo mentioned this pull request Jun 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djrtwo @protolambda