Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change data structure order to mirror beacon state property order #1141

Merged
merged 4 commits into from
Jun 5, 2019

Conversation

0xKiwi
Copy link
Contributor

@0xKiwi 0xKiwi commented Jun 5, 2019

I'm not sure what the logic behind the sorting of the Misc dependencies data structures is but this PR changes the order to be more inline with the order they're used in Beacon State.

I'm always confused on the order whenever I check the spec so hopefully this makes it a tad more consistent.

If something like this is not needed feel free to let me know :)

Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine.
Due to the way we build the spec, the datastructures need to be sorted topologically (any dependencies coming earlier). That's why we have this crappy "Misc" category.

@djrtwo djrtwo merged commit 6feede7 into ethereum:dev Jun 5, 2019
@dankrad
Copy link
Contributor

dankrad commented Jun 6, 2019

Due to the way we build the spec, the datastructures need to be sorted topologically (any dependencies coming earlier). That's why we have this crappy "Misc" category.

I think Carl fixed this in #1061. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants