Added backward argument to block headers request #1100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok to me. LES uses the word |
|
I don't mind rewording to |
JustinDrake
reviewed
Jun 8, 2019
specs/networking/rpc-interface.md
Outdated
| @@ -225,6 +225,7 @@ Requests a list of block roots and slots from the peer. The `count` parameter MU | |||
| start_slot: uint64 | |||
| max_headers: uint64 | |||
| skip_slots: uint64 | |||
| backward: uint8 in {0, 1} | |||
There was a problem hiding this comment.
Should this be of type bool?
There was a problem hiding this comment.
Yes, semantically this is a bool. Spec-wise though I didn't find any occurrences of bool to date, and went kinda the same way it was done in eth1 wire spec. Should I change it to bool instead?
There was a problem hiding this comment.
|
closing in favor of #1281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
backwardoption is useful for obtaining the branches we're missing for some reason, but getting attestations to.