update shuffling func name #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note 1: merging into
v06xbranch. The intention here is not to pollute the master branch for fixes to the latest release. And then mergev06xinto master for a newv0.6.xrelease, and merge into dev to port over fixes + testing improvements.Note 2: a near-term goal of mine is to generalize the setup of some of the pytests and generators, and hopefully catch these types of problems earlier, and have more tests generated based on the pytests effort (it's understandable people prioritize testing the spec over providing tests for implementers, but I do want to see more consistency between the two).
The generator broke because of #1009 renaming
get_permuted_indextoget_shuffled_index. Fixed that.