Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify builder signing domain #39

Merged
merged 2 commits into from
Jul 29, 2022
Merged

clarify builder signing domain #39

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
325ee9c
clarify builder signing domain
tersec Jul 19, 2022
8f68a98
address review comments
tersec Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion specs/builder.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ There are two types of data to sign over in the Builder API:
and use the domain specified for beacon block proposals.
* Builder API messages, e.g. validator registration, which should compute the
signing root using [`compute_signing_root`][compute-root] with domain given by
`compute_domain(DOMAIN_APPLICATION_BUILDER)`.
`compute_domain(DOMAIN_APPLICATION_BUILDER)` relative to the genesis fork and
with a zero genesis validators root.
As `compute_signing_root` takes `SSZObject` as input, client software should
convert in-protocol messages to their SSZ representation to compute the signing
root and Builder API messages to the SSZ representations defined
Expand Down